Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deck migration/draw layer #2629

Merged

Conversation

weberjavi
Copy link
Collaborator

No description provided.

@global-fishing-watch-bot
Copy link

Automatic is false. You need to set a label deploy-dev, deploy-staging o deploy-pro to run the preview the environment

Copy link
Collaborator

@j8seangel j8seangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the useDrawLayer has become is too complicated, I'd try to simplify it moving to the deck-layers library, we can review it together.

I'd like to avoid the map?.setProps({ controller: { dragPan: false } }) and deck?.setProps({ getCursor: () => 'move' }) but haven't realized a better way yet so I will give it another try later and let's brainstorm ideas next week.

There are still some features pending, using a list so we don't forget it:

  • We should disable the hover effect while rendering rulers
image
  • The self-intersection warning (kinks) is not working while editing
  • Edit a coordinate in the tooltip moves the tooltip but not the feature

apps/fishing-map/features/map/popups/PopupWrapper.tsx Outdated Show resolved Hide resolved
apps/fishing-map/features/map/Map.tsx Outdated Show resolved Hide resolved
@j8seangel j8seangel changed the title Deck migration/draw layer leftovers Deck migration/draw layer Jun 10, 2024
@j8seangel
Copy link
Collaborator

j8seangel commented Jun 10, 2024

Pending things TODO:

  • Deactivate click selection while drawing
  • Render draw points layer
  • Icon for points features draw
  • Clicking on other area doesn't work until you click outside
  • Fix draw hover and click tooltip labels

@j8seangel
Copy link
Collaborator

Keep working on edition PR

@j8seangel j8seangel marked this pull request as ready for review June 10, 2024 19:07
@j8seangel j8seangel merged commit 65cd2ec into deck-migration/base-branch Jun 10, 2024
1 check passed
@j8seangel j8seangel deleted the deck-migration/draw-layer-leftovers branch June 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants