Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create vesselGroups from vessel section #2808

Merged
merged 23 commits into from
Aug 30, 2024
Merged

create vesselGroups from vessel section #2808

merged 23 commits into from
Aug 30, 2024

Conversation

j8seangel
Copy link
Collaborator

@j8seangel j8seangel commented Aug 28, 2024 •
edited
Loading

  • Vessel group creation:

    • Create group from vessels section
    • Deactivate when no vessels visible
    • Create new group shows the modal
    • Add to existing vessel group automatically instead of edit
    • Skip adding the vesselGroup if already in workspace
    • Add vessel group to workspace after creation in modal

  • Other related things:

    • Add close vessel group report button
    • Show warning on deleted user group in sidebar
    • Don't show vessel group name until loaded
    • VesselGroupLayer panel missing icons: edit and report
    • Vessel group dataview with all sources

@global-fishing-watch-bot
Copy link

Automatic is false. You need to set a label deploy-dev, deploy-staging o deploy-pro to run the preview the environment

Base automatically changed from fishing-map/vessel-profile-route to fishing-map/vessel-profile-3 August 29, 2024 08:36
@j8seangel j8seangel force-pushed the fishing-map/vessel-profile-group-creation branch 6 times, most recently from 62cab94 to 3119f13 Compare August 30, 2024 12:52
j8seangel and others added 18 commits August 30, 2024 16:33
@j8seangel
create vesselGroups from vessel section
f767df8
@j8seangel
fix build
8a66431
@j8seangel
fix userVesselGroups icon styles
2137a52
@j8seangel
fix back vesselGroup
33771db
@j8seangel
add to existing vesselGroup directly
a7962bb
@j8seangel
not duplicate vessel groups on update
83bea44
@j8seangel
avoid request vessel groups multiple times
e891aed
@j8seangel
include all sources in vessel groups instance
ee79077
@j8seangel
fix disabled vesselGroupAdd button
bee4226
@j8seangel
fix vesselGroupModal height
411e002
@j8seangel
add vesselGroup layer from modal creation
452fbf3
@satellitestudiodesign @j8seangel
also show "add to group" when a single vessel is visible
6ad99b4
@j8seangel
fix upper case in vesselGroups list
3ed8a27
@j8seangel
refactor to cleanup types and follow are-report state config
a2aa4d1
@j8seangel
clean all report params at once
7f4bb76
@j8seangel
show edit icon in LayerPanel
7058068
@j8seangel
go to report link icon
999767f
@j8seangel
deleted and loading VesselGroupLayerPanel state
30ec6bb
@j8seangel j8seangel force-pushed the fishing-map/vessel-profile-group-creation branch from b451b81 to 30ec6bb Compare August 30, 2024 14:33
@j8seangel j8seangel merged commit a9ff701 into fishing-map/vessel-profile-3 Aug 30, 2024
1 check passed
@j8seangel j8seangel deleted the fishing-map/vessel-profile-group-creation branch August 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api-types dataviews-client deck-layer-composer deck-layers fishing-map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j8seangel @satellitestudiodesign