Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VV3 analytics #2879

Merged
merged 7 commits into from
Oct 24, 2024
Merged

VV3 analytics #2879

merged 7 commits into from
Oct 24, 2024

Conversation

weberjavi
Copy link
Collaborator

@weberjavi weberjavi commented Oct 23, 2024 •
edited
Loading

Events on this spreadsheet (rows 77 to 111)

@global-fishing-watch-bot
Copy link

Automatic is false. You need to set a label deploy-dev, deploy-staging o deploy-pro to run the preview the environment

@weberjavi weberjavi marked this pull request as ready for review October 23, 2024 23:12
satellitestudiodesign
satellitestudiodesign approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@satellitestudiodesign satellitestudiodesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sending percentages of VMS and specific vesselIDs is a bit "overkill", but we can review it with the team later.
Otherwise it looks great :)

@satellitestudiodesign satellitestudiodesign merged commit 5358052 into develop Oct 24, 2024
1 check passed
@satellitestudiodesign satellitestudiodesign deleted the fishing-map/vv3-google-analytics branch October 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satellitestudiodesign satellitestudiodesign satellitestudiodesign approved these changes

Assignees
No one assigned
Labels
fishing-map
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weberjavi @satellitestudiodesign