Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dapp images #414

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

zbraiterman
Copy link
Contributor

@zbraiterman zbraiterman commented Nov 11, 2021

I’ve made the following changes, based on feedback I’ve received from @plotnick on my previous pull request (#409):

  • Changed the directory from resources to dpps/images
  • Removed the Glow logo (I believe that was the “spurious glow executable to which @plotnick had referred).

Copy link
Contributor

@zenhack zenhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the file glow at the root of the repository is the "spurrious executable" @plotnick was talking about. Looking at it, it looks like you overwrote the file with the logo image, but originally this was a script; I suspect Alex skimmed the changes and mistakenly believed you'd committed a compiled executable.

This file should be reverted to what it was on master:

git checkout origin/master -- glow

### Being worked on

You can watch our [GitHub repository](https://github.com/Glow-Lang/glow)
for current developments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @plotnick mentioned in #411, the link to the GitHub repo does still make sense, since the README can be viewed from a local checkout, not just on GitHub.

@zenhack
Copy link
Contributor

zenhack commented Nov 11, 2021

(Also, for the future, you don't need to open a second pull request to make changes; you can just add more changes to the existing branch and push, and it will update the original pr)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants