Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert external dns back to v6 #343

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

venkatamutyala
Copy link
Contributor

@venkatamutyala venkatamutyala commented Jun 19, 2024

User description

There appear to be bugs in v7 helm chart: bitnami/charts#25967


PR Type

Bug fix


Description


Changes walkthrough 📝

Relevant files
Bug fix
application-external-dns.yaml
Revert external-dns Helm chart version due to bugs             

templates/application-external-dns.yaml

  • Reverted external-dns Helm chart version from 7.5.7 to 6.38.0.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    Copy link

    sonarcloud bot commented Jun 19, 2024

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    No data about Coverage
    0.0% Duplication on New Code

    See analysis details on SonarCloud

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Lock the external-dns chart version to a specific patch for increased stability

    Consider locking the version of the external-dns chart to a specific patch version for
    better stability and predictability in deployments. Using a more specific version can help
    avoid unexpected issues if minor updates are made to the 6.38.x series.

    templates/application-external-dns.yaml [29]

    -targetRevision: 6.38.0
    +targetRevision: 6.38.0  # Consider using a specific patch version, e.g., 6.38.2
     
    Suggestion importance[1-10]: 8

    Why: The suggestion to lock the version to a specific patch version is a best practice for stability and predictability in deployments. It helps avoid unexpected issues from minor updates.

    8

    @venkatamutyala venkatamutyala merged commit b380820 into main Jun 19, 2024
    3 checks passed
    @venkatamutyala venkatamutyala deleted the fix/revert-external-dns branch June 19, 2024 17:13
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants