-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Assistant Field Order #343
base: stable
Are you sure you want to change the base?
Conversation
Describe fields in same order as form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only the order changed:
-
This labels were also renamed to remove ambiguity.
-
Also the colons were removed from the labels — in the whole dialog.
-
I wonder, if you could also insert a screenshot like in the german version
-
and perhaps apply the new style with
<gloss*>
instead of<emphasis role="bold">
?
@@ -5457,6 +5457,21 @@ | |||
</para> | |||
|
|||
<itemizedlist> | |||
<listitem> | |||
<para><emphasis role="bold">Name:</emphasis> The full name of the commodity is a recognizable name such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<emphasis role="bold">Full name</emphasis>
</listitem> | ||
|
||
<listitem> | ||
<para><emphasis role="bold">Symbol:</emphasis> Indicates the symbol or abbreviation for the commodity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<emphasis role="bold">Symbol/abbreviation</emphasis>
But it's complicated and I suppose ultimately this PR will be closed without merging.
How about a critique?
Doesn't seem relevant to this section which has a consistent style with the rest of the document.
Screenshots from random version/OSs look scrappy (English version).
Isn't this something that could be scripted in the repo across all docs/languages? This is one of the downsides of complicated markup compared to something like markdown. |
@CWehli missed I your backport of ch_Tools_Assistants.docbook or have you aready something prepared? |
We try to avoid renaming english terms because over 60 translators of the program and the documenters have to apply the change, too. |
Right, Google translate would understand |
Well, Google translate would understand "name" and "space" but that wouldn't necessarily convey the same meaning. After all "namespace" is computer science jargon so it's not going to be meaningful to normal people anyway. I think "type" is a bit too restrictive, how about "Commodity Group"? |
Describe fields in same order as form
Replaces #342