Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meteorite Staff to Weapons List #50

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

cassianoblonski
Copy link
Contributor

@cassianoblonski cassianoblonski commented Jun 16, 2024

The Glintstone Staves Checklist didn't had Meteorite Staff.

Proposed Solution

@Gobluebro I don't know how this ID works, can you help me with it? Or commit it, if you prefer.

      {
        id: "comment-the-rule-to-gen-this-id",
        description: rawHTMLLink(
          "https://eldenring.wiki.fextralife.com/Meteorite+Staff",
          "Meteorite Staff"
        ),
      },

@Gobluebro Gobluebro self-requested a review June 17, 2024 00:02
@Gobluebro Gobluebro added the bug / missing / incomplete Something isn't right label Jun 17, 2024
@Gobluebro
Copy link
Owner

Good catch.

I don't know how this ID works, can you help me with it?

I use a VSCode extension called "Insert GUID"
but you could always do in a javascript console

crypto.randomUUID();
// "fcc8bb8f-acdb-4687-8fc6-90ae6347b2be"

and receive an ID there as well.

I went ahead and added the ID.
Thanks for the help!

@Gobluebro Gobluebro merged commit 63bbc26 into Gobluebro:main Jun 17, 2024
1 check passed
@cassianoblonski cassianoblonski deleted the patch-1 branch June 24, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / missing / incomplete Something isn't right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants