-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐛 match any character between func name and (
#495
Open
KANAjetzt
wants to merge
8
commits into
GodotModding:4.x
Choose a base branch
from
KANAjetzt:fix_match_func
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
commented
Dec 23, 2024
KANAjetzt
force-pushed
the
fix_match_func
branch
2 times, most recently
from
December 25, 2024 10:40
b721387
to
c1e7e92
Compare
1 task
KANAjetzt
force-pushed
the
fix_match_func
branch
from
December 29, 2024 09:32
7d9b772
to
3295d24
Compare
moved the regex string to the top and added a description
and word boundary for the method name
It only handled one specific case, `#func`. Something like `# ` was still matched. To avoid giving a false impression, I removed it, and this case is now also handled by `is_top_level_func()`.
KANAjetzt
force-pushed
the
fix_match_func
branch
from
January 9, 2025 13:30
3295d24
to
293aee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func\\s+%s[\\\\\\s]*\\(
to\\bfunc\\b\\s+\\b%s\\b(?:.*\\n*)*?\\s*\\(
is_top_level_func()
and not handled by this regexTested with #476 and a smaller game via export plugin on 4.3.
closes #494