Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route signaling for storage + script versioning #90

Merged
merged 5 commits into from
Feb 1, 2021
Merged

Conversation

fenix-hub
Copy link
Contributor

@fenix-hub fenix-hub commented Feb 1, 2021

This PR will add higher level signals for Storage module
(plus some minimal versioning for scripts)
#88

@fenix-hub
Copy link
Contributor Author

@SIsilicon Here it is, feel free to check it out and edit it

@SIsilicon
Copy link
Contributor

@fenix-hub Looks great! Just a couple things that need to change.

Copy link
Contributor

@SIsilicon SIsilicon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wanna remove your firebase configuration from the project.

project.godot Outdated Show resolved Hide resolved
addons/godot-firebase/storage/storage.gd Outdated Show resolved Hide resolved
@fenix-hub
Copy link
Contributor Author

@SIsilicon Thanks for your help. I'll merge this :)

@fenix-hub fenix-hub merged commit 27c2478 into main Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants