Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTC tracker support #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BastiaanOlij
Copy link
Member

@BastiaanOlij BastiaanOlij commented Mar 9, 2022

This is a port of the code I've already added in Godot 4 with some changes due to how things work in Godot 3.
Note that we're currently waiting on a fix in SteamVR to be applied and that I'm having a crash issue I'm still investigating.

Other then that this is pretty much finished. One major change that is required for implementing this correctly is that we now create all positional trackers in Godot at startup, this to reserve the needed controller ids and not have them changing as trackers are turned off/on. This may require some more testing to make sure we're correctly reacting to trackers marked as inactive/not tracking.

Also that has had an impact on the implementation of trackers for hand tracking. This may require more testing.

@BastiaanOlij BastiaanOlij force-pushed the htc_vive_tracker_support branch from c1a3608 to 6ef03d9 Compare March 9, 2022 09:02
@BastiaanOlij BastiaanOlij self-assigned this Mar 9, 2022
@BastiaanOlij BastiaanOlij added enhancement New feature or request SteamVR Related to SteamVR labels Mar 9, 2022
@BastiaanOlij BastiaanOlij added this to the 1.3.0 milestone Mar 9, 2022
@BastiaanOlij
Copy link
Member Author

Small update on this, Valve has a fix in beta that resolves the issue with poses not being retrieved correct once the HTC extension is enabled. There are still some issues with detection but will be working on those soon.

@BastiaanOlij BastiaanOlij force-pushed the htc_vive_tracker_support branch 2 times, most recently from d45b7d6 to 700acd1 Compare April 25, 2022 06:42
@BastiaanOlij BastiaanOlij force-pushed the htc_vive_tracker_support branch from 700acd1 to d0aafbd Compare April 25, 2022 06:47
@BastiaanOlij BastiaanOlij marked this pull request as ready for review May 26, 2022 06:41
@BastiaanOlij
Copy link
Member Author

I need to do some testing but now that a new SteamVR is out that has a fix we were waiting for, we should be able to merge this soon.

@BastiaanOlij BastiaanOlij modified the milestones: 1.3.0, 1.4.0 Jun 1, 2022
@BastiaanOlij BastiaanOlij added the needs-testing Needs Testing label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-testing Needs Testing SteamVR Related to SteamVR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant