enabled web-vitals-extension loggin option #80
Conversation
|
Here's an example of the Console Logging output. All the LCP and CLS intermediate values will be logged, also including the latest "entries" object to allow an easy identification of the DOM elements causing the metric timing.
|
|
This is a great feature! Reduces the anxiety of having to click the extension at the right time without doing anything else that might interfere with what you wanted to measure! |
src/browser_action/vitals.js
Outdated
| @@ -210,12 +219,21 @@ | |||
| // of animations or highly-dynamic content, we | |||
| // debounce the broadcast of the metric. | |||
| latestCLS = metric; | |||
| if(enableLogging) { | |||
There was a problem hiding this comment.
Should each of these metrics' logs be moved to broadcastMetricsUpdates? That will also debounce the CLS logging to prevent console spam.
One other suggestion is to prefix the log message with something identifiable for filtering, eg "[Web Vitals] "
There was a problem hiding this comment.
Hi @rviscomi , thanks for your feedback.
Yes I agree with you, at first I've added the logging within broadcastMetricsUpdates but then I've moved to the getMetricName method because I wanted to create one line per Metric logging.
I've moved the logging to that method, I thought about keeping the metric value rounded toFixed(2) in the first logging value and send as last log entry the whole metric object.
Maybe we can support different logging levels, such as debug (metric name + value) and verbose (metric name, value, metric object with all the entries).
WDYT?
Below the example screenshot
There was a problem hiding this comment.
Maybe we can support different logging levels, such as debug (metric name + value) and verbose (metric name, value, metric object with all the entries).
WDYT?
I think the way you have it here is a good first step for this PR and we can keep #77 open to revisit it with enhancements like the one you suggested.
There was a problem hiding this comment.
LGTM!
I'll defer to @addyosmani to give this one last look before merging.
Progress on #77
Added Console Log Options to enable all CWV Metrics logging via console.