fix: distribute tsconfig and rollup config files #522
Closed
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We currently distribute the source code for the project, but not the
configuration files, meaning that users cannot build the project. This commit
adds the tsconfig.json and rollup.config.js files to the distributed package.
Test Plan:
npm run build
and ensure that the project builds successfullynpm install && cd node_modules/web-vitals && npm install --ignore-scripts && npm run build
and ensure thatthe project builds successfully
Motivation:
I am currently working on a patch for the web vitals Chrome extension and need
to use a development build of this web-vitals package. To do that, I want to make a patch like
however, the
npm run build
part fails because we don't distributetsconfig.json
androllup.config.js
. This commit fixes that.