Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CSS and HTML parser. #120

Closed
wants to merge 3 commits into from
Closed

Updating CSS and HTML parser. #120

wants to merge 3 commits into from

Conversation

janicklas-ralph
Copy link
Collaborator

@janicklas-ralph janicklas-ralph commented May 4, 2023

Updating HTML parser to use htmlparser2 and updating css-select and postcss versions.

cc: @alan-agius4

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.
LGTM, after updating the package.json

packages/critters/package.json Show resolved Hide resolved
Comment on lines 52 to 53
"parse5": "^6.0.1",
"parse5-htmlparser2-tree-adapter": "^6.0.1",
Copy link
Contributor

@alan-agius4 alan-agius4 May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed

Suggested change
"parse5": "^6.0.1",
"parse5-htmlparser2-tree-adapter": "^6.0.1",

@alan-agius4
Copy link
Contributor

This should solve #103

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants