Simplify how default values are set for complex variables types. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes "Terraform applies the default value you specify in the optional modifier first and then later applies any nested default values to that attribute" which means that the values specified in "optional" constraints was **always** overridden immediately by the defaults specified below. This change simplifies how the defaults are set, solely using the optional defaults.
|
/gcbrun |
|
@roberthbailey Is this PR still active? Can you resolve conflicts if so? |
|
I had forgotten about this PR. At this point I'm going to close it and I will re-open a new one if this bothers me again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes
"Terraform applies the default value you specify in the optional modifier first and then later applies any nested default values to that attribute"
which means that the values specified in "optional" constraints was always overridden immediately by the defaults specified below.
This change simplifies how the defaults are set, solely using the optional defaults.