Decrease scrape interval of metrics from TGI and DCGM to 15s in benchmark #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. To facilitate this, also decrease DCGM's interval to 5s to ensure fresh metrics.
raywainman
requested review from
achandrasekar,
ahg-g and
annapendleton
as code owners
raywainman
changed the title
...marks/inference-server/text-generation-inference/hpa-templates/dcgm-podmonitoring.yaml.tftpl
Show resolved
Hide resolved
annapendleton
approved these changes
Aug 8, 2024
achandrasekar
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease scrape interval of metrics from TGI and DCGM from 30s to 15s in benchmark, this will allow for quicker autoscaling and also for better graphs when plotting the data.
To do this, we need to export data out of DCGM more often (here I have it set to 5s by setting the
collect-intervalflag).