chore: prefer publicKey over pemCSR in API
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| with open(ca_filename, "w+") as ca_out: | ||
| ca_out.write("".join(cert_chain)) | ||
| with open(cert_chain_filename, "w+") as chain_out: | ||
| chain_out.write("".join(full_chain)) | ||
| chain_out.write("".join(cert_chain)) |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information
| with open(ca_filename, "w+") as ca_out: | ||
| ca_out.write("".join(cert_chain)) | ||
| ca_out.write(ca_cert) |
Check failure
Code scanning / CodeQL
Clear-text storage of sensitive information
jackwotherspoon
requested review from
cthumuluru,
nancynh and
a team
as code owners
jackwotherspoon
changed the title
publicKey over pemCSR in API
enocom
approved these changes
Oct 24, 2023
@enocom its nots part of the lint its part of the security scan. I've already marked them as false positives so they won't show up in future PRs I believe. Should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer
publicKeyoverpemCSRin API request body.Will follow up after this PR with #14 to make key generation async and non-blocking
Closes #110