Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support native asyncpg connection pools #409

Conversation

rhatgadkar-goog
Copy link
Collaborator

@rhatgadkar-goog rhatgadkar-goog commented Jan 9, 2025

This change is analogous to CloudSQL's change:
GoogleCloudPlatform/cloud-sql-python-connector#1182

@rhatgadkar-goog rhatgadkar-goog linked an issue Jan 9, 2025 that may be closed by this pull request
@rhatgadkar-goog rhatgadkar-goog force-pushed the 382-add-docs-and-integration-test-for-native-asyncpg-connection-pool branch from 0bed674 to d81da4f Compare January 9, 2025 01:04
@rhatgadkar-goog rhatgadkar-goog marked this pull request as ready for review January 9, 2025 01:14
@rhatgadkar-goog rhatgadkar-goog requested a review from a team as a code owner January 9, 2025 01:14
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rhatgadkar-goog rhatgadkar-goog merged commit ea2a524 into main Jan 9, 2025
15 checks passed
@rhatgadkar-goog rhatgadkar-goog deleted the 382-add-docs-and-integration-test-for-native-asyncpg-connection-pool branch January 9, 2025 17:54
rhatgadkar-goog added a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs and integration test for native asyncpg connection pool
4 participants