Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Cast value to str in EnumConverter before calling value.upper() #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2017

As reported on the Cloud Platform issue tracker, EnumConverter does not care if the value to be converted to an enum is a str before trying to call value.upper(). This causes a crash in the case of redirect_http_response_code which takes int values.

Always casting value to a str first avoids this problem.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant