Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Cody Goldberg <[email protected]>
  • Loading branch information
kevmoo and prefanatic authored Jul 7, 2023
1 parent 1a36004 commit efd5c2b
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions gcp/lib/src/metadata.dart
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,8 @@ enum MetadataValue {
return result;
}

/// Returns the
/// [Region](https://cloud.google.com/compute/docs/regions-zones#identifying_a_region_or_zone)
/// for the current instance by checking the environment variables in
/// [environmentValues].
///
/// Returns a metadata value for the current instance by checking the
/// environment variables in [environmentVariables].
/// The list is checked in order. This is useful for local development.
///
/// If no matching variable is found, `null` is returned.
Expand All @@ -98,10 +95,8 @@ enum MetadataValue {
return null;
}

/// Returns a [Future] that completes with the
/// [Region](https://cloud.google.com/compute/docs/regions-zones#identifying_a_region_or_zone)
/// for the current instance by checking
/// [instance metadata](https://cloud.google.com/compute/docs/metadata/default-metadata-values#vm_instance_metadata).
/// Returns a [Future] that completes with a metadata value for the current
/// instance by contacting the metadata server.
///
/// If the metadata server cannot be contacted, a [BadConfigurationException]
/// is thrown.
Expand Down

0 comments on commit efd5c2b

Please sign in to comment.