Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base resource requests on actual usage #2540

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Base resource requests on actual usage #2540

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4898b69
Base resource requests on actual usage
NimJay May 10, 2024
a5966ce
Update limits by adding 20 to requests
NimJay May 10, 2024
83d2c59
Merge branch 'main' into nimjay-resource-requests
NimJay May 14, 2024
3c85dec
Merge branch 'main' into nimjay-resource-requests
kweinmeister Jun 2, 2024
531e293
Update based on Kind testing
NimJay Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions kubernetes-manifests/adservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ spec:
value: "9555"
resources:
requests:
cpu: 200m
memory: 180Mi
cpu: 60m
memory: 80Mi
limits:
cpu: 300m
memory: 300Mi
cpu: 80m
memory: 100Mi
readinessProbe:
initialDelaySeconds: 20
periodSeconds: 15
Expand Down
10 changes: 5 additions & 5 deletions kubernetes-manifests/cartservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ spec:
resources:
requests:
cpu: 200m
memory: 64Mi
memory: 70Mi
limits:
cpu: 300m
memory: 128Mi
cpu: 220m
memory: 90Mi
readinessProbe:
initialDelaySeconds: 15
grpc:
Expand Down Expand Up @@ -134,8 +134,8 @@ spec:
memory: 256Mi
cpu: 125m
requests:
cpu: 70m
memory: 200Mi
cpu: 20m
memory: 70Mi
volumes:
- name: redis-data
emptyDir: {}
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/checkoutservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@ spec:
value: "cartservice:7070"
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 10m
memory: 20Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 30m
memory: 40Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/currencyservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ spec:
port: 7000
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 20m
memory: 40Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 40m
memory: 60Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/emailservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,11 @@ spec:
port: 8080
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 10m
memory: 50Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 30m
memory: 70Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/frontend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,11 @@ spec:
# value: "" # This value would look like "http://123.123.123"
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 20m
memory: 20Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 40m
memory: 40Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/loadgenerator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ spec:
value: "10"
resources:
requests:
cpu: 300m
memory: 256Mi
cpu: 10m
memory: 200Mi
limits:
cpu: 500m
memory: 512Mi
cpu: 30m
memory: 220Mi
---
apiVersion: v1
kind: ServiceAccount
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/paymentservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ spec:
port: 50051
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 10m
memory: 30Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 30m
memory: 50Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/productcatalogservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ spec:
port: 3550
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 10m
memory: 20Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 30m
memory: 40Mi
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/recommendationservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ spec:
value: "1"
resources:
requests:
cpu: 100m
memory: 220Mi
cpu: 10m
memory: 10Mi
NimJay marked this conversation as resolved.
Show resolved Hide resolved
limits:
cpu: 200m
memory: 450Mi
cpu: 30m
memory: 30Mi
Copy link
Contributor

@mathieu-benoit mathieu-benoit Jun 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting OOMKilled with this on a brand new Kind cluster locally, let's have 70Mi in limits and 50Mi in requests like the other Python app emailservice has?

NimJay marked this conversation as resolved.
Show resolved Hide resolved
---
apiVersion: v1
kind: Service
Expand Down
8 changes: 4 additions & 4 deletions kubernetes-manifests/shippingservice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ spec:
port: 50051
resources:
requests:
cpu: 100m
memory: 64Mi
cpu: 10m
memory: 10Mi
limits:
cpu: 200m
memory: 128Mi
cpu: 30m
memory: 30Mi
---
apiVersion: v1
kind: Service
Expand Down
Loading