-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove KFP presubmit SDK misc tests prow config #2327
chore: Remove KFP presubmit SDK misc tests prow config #2327
Conversation
Hi @DharmitD. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
eb91e3f
to
78aa7ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DharmitD can you rebase?
78aa7ff
to
af664c3
Compare
@@ -97,16 +97,28 @@ presubmits: | |||
command: | |||
- ./test/presubmit-tests-tfx.sh | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not resolve merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed like a git push issue. Pushed again, should be resolved and rebased correctly now. Could you please approve?
af664c3
to
3342e25
Compare
3342e25
to
9768df0
Compare
@chensun related Migration PR is merged: kubeflow/pipelines#11032 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b465ac0
into
GoogleCloudPlatform:master
@DharmitD: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
As part of migration from Prow to GH Action Workflows for KFP, we have a PR proposed to migrate KFP SDK misc tests to a GHA: kubeflow/pipelines#11032
This PR removes presubmit SDK tests from the prow config in parallel.