Integrated Github Actions into tide #2352
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: VaniHaripriya The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @VaniHaripriya. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| pipelines: | ||
| protect: true | ||
| required_status_checks: | ||
| contexts: |
There was a problem hiding this comment.
I'm unsure of what the context field implies here, and whether listing GHA titles here is the right approach.
@chensun any ideas on how we could integrate these GHA workflows into tide? Thanks!
There was a problem hiding this comment.
Tide has minimal support for GHA and I have not used it myself so I'm not very familiar with how supported this is or what the UX would be like. At minimum, Tide cannot retest GHA and GHA does not respect the presubmit checkout semantics that are expected by Tide (merging into the base branch at a specific commit before testing).
There was a problem hiding this comment.
@cjwagner Could you suggest if adding branch protection rules to the KFP repo by specifying the GH Action workflows in the Require status checks to pass before merging would be a good option to consider. We can continue using /rerun-all label to rerun the failed tests.
There was a problem hiding this comment.
@VaniHaripriya are you sure you are supposed to put workflow name here for contexts, and not the job name? https://stackoverflow.com/questions/69177488/how-to-set-github-actions-as-required-status-checks
There was a problem hiding this comment.
@HumairAK That's correct. We should provide the job name, I will correct it once we decide which option to proceed with(Integrating GH Action to Tide or to set up branch protection rules).
There was a problem hiding this comment.
@VaniHaripriya Sorry, I don't know enough about the behavior/support for GHA to tell you whether that will work or not.
I would expect it to be safe to try our and revert if it doesn't behave as desired (especially if you just tried this on a less active repo first).
As part of migration from Prow to GH Action Workflows for KFP, integrated the Github Actions into tide to block the PRs from merging in case of any failing tests.