Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(samples): removing iot samples #1935

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

vishwarajanand
Copy link
Member

@vishwarajanand vishwarajanand commented Oct 27, 2023

Description

Removing deprecated IOT samples.
Fixes: googleapis/google-cloud-php#6727

Changes

  1. Removed all fiels under /iot/src and /iot/test
  2. Removed iot/composer.json and the phpunit configs
  3. Removed GOOGLE_IOT_DEVICE_CERTIFICATE_B64 froms ecrets sample and the actual secrets file.
  4. Removed iot from testing/* scripts

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 27, 2023
@vishwarajanand vishwarajanand marked this pull request as ready for review October 27, 2023 09:19
@vishwarajanand vishwarajanand requested review from a team as code owners October 27, 2023 09:19
@snippet-bot
Copy link

snippet-bot bot commented Oct 27, 2023

Here is the summary of changes.

You are about to delete 25 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@yash30201 yash30201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yash30201 yash30201 merged commit 461c088 into GoogleCloudPlatform:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IoT library after IoT deprecation?
2 participants