Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove create_ssl_certificate (used with private_key/certificate) #276

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Dec 11, 2024

Per use_ssl_certificates-is-replaced-with-create_ssl_certificate, create_ssl_certificate is only used when providing private_key and certificate. Providing ssl_certificates OR managed_ssl_certificate_domains is sufficient, and is guarded by the variable constraint.

Fixes: #265

@apeabody apeabody requested review from prabhu34, anamer, gtsorbo, q2w and a team as code owners December 11, 2024 19:41
@apeabody
Copy link
Contributor Author

Hi @prabhu34 - Can you please take a look? Thanks!

@prabhu34
Copy link
Collaborator

Hi @prabhu34 - Can you please take a look? Thanks!

Noted @apeabody. I am on BBL. Apologies for the delays!

@apeabody
Copy link
Contributor Author

Hi @prabhu34 - Can you please take a look? Thanks!

Noted @apeabody. I am on BBL. Apologies for the delays!

No reason to apologize :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

secure-cloud-run-core loadbalancer.tf and ssl_certificates input
2 participants