try all keys for NDI #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gyunikuchan
reviewed
Apr 17, 2024
src/corppass/corppass-helper-ndi.ts
Outdated
| error = err; | ||
| } | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
Is it safe to simply throw error;?
Or should we be doing a check on whether there's an error before throwing?
There was a problem hiding this comment.
ideally if it reaches there it means all of the verification failed and there should be at least one error; of course to be extra safe it can be
if (error) {
throw error;
} else {
throw new Error('all keys failed');
}
Gyunikuchan
reviewed
Apr 17, 2024
src/corppass/corppass-helper-ndi.ts
Outdated
| error = err; | ||
| } | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
Is it safe to simply throw error;?
Or should we be doing a check on whether there's an error before throwing?
Gyunikuchan
reviewed
Apr 17, 2024
src/singpass/singpass-helper-ndi.ts
Outdated
| error = err; | ||
| } | ||
| } | ||
| throw error; |
There was a problem hiding this comment.
Is it safe to simply throw error;?
Or should we be doing a check on whether there's an error before throwing?
Gyunikuchan
reviewed
Apr 17, 2024
Gyunikuchan
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDI is doing a key rotation and randomises the order of old and new keys, so we have to try them all