Skip to content

Commit

Permalink
Try to resolve plugin sign failure
Browse files Browse the repository at this point in the history
https://github.com/Gowee/traceroute-map-panel/runs/2146736283?check_suite_focus=true

Error:

> Run npx @grafana/toolkit plugin:sign
> Invalid command: plugin:sign
> See --help for a list of available commands.

The problem appears to be that npx attempts to install and then use another
outdated version of @grafana/toolkit in global somehow. The mysterious
behaviours can be reproduced on node:12 altough almost the same workflow
works well when releasing v0.3.0-beta2. Anyway, just wrap
@grafana/toolkit command in package.json commands. Besides, node version
for CI runner is also upgraded, to 15.
  • Loading branch information
Gowee committed Mar 19, 2021
1 parent 4731ce4 commit 9d3663e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: '12'
node-version: '15'
- run: yarn install
- run: yarn build
- run: yarn ci # no effective test so far, just to make sure it lints & builds well
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
git merge "${GITHUB_REF#refs/heads/}"
- uses: actions/setup-node@v1
with:
node-version: '12'
node-version: '15'
- name: Init
run:
yarn install
Expand All @@ -38,7 +38,7 @@ jobs:
env: # Or as an environment variable
GRAFANA_API_KEY: ${{ secrets.GRAFANA_API_KEY }}
run:
npx @grafana/toolkit plugin:sign
yarn sign
- name: Create tarball
run:
tar czf /tmp/dist.tar.gz --transform s/^dist/traceroute-map-panel/ dist/
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
"dev": "grafana-toolkit plugin:dev",
"watch": "grafana-toolkit plugin:dev --watch",
"ci": "grafana-toolkit plugin:ci-build",
"sign": "grafana-toolkit plugin:sign",
"start": "yarn watch",
"lint": "eslint -c node_modules/@grafana/toolkit/src/config/eslint.plugin.json src --ext js,jsx,ts,tsx"
},
"repository": "github:gowee/traceroute-map-panel",
Expand Down

0 comments on commit 9d3663e

Please sign in to comment.