Merge branch 'alignment-in-data-segment' into 'main'

Allow alignment in data_segment

Closes rewriting/transforms/gtirb-sysenforce#8

See merge request rewriting/ddisasm!1219

CHANGELOG.md

@@ -16,6 +16,8 @@
 * Fix symbolization bug of ADR instructions in ARM32 that refer to code.
 * Fix bug in PE code inference that could lead to the whole .text section being
   declared invalid if a data directory was attached to the end of the section.
+* Add alignments to data blocks that require alignment even within data
+  sections
 
 # 1.9.0
 

src/datalog/main.dl

@@ -698,11 +698,12 @@ the max alignment is picked for an EA later.
 // requires aligned memory: e.g., some SIMD instructions
 alignment_candidate(DataEA, AlignInBits):-
     arch.alignment_required(EA,AlignInBits),
+    code(EA),
     (
         pc_relative_operand(EA,_,DataEA);
         composite_data_access(_,EA,DataEA,AlignInBits)
     ),
-    data_in_code(Begin,End),
+    data_segment(Begin,End),
     DataEA >= Begin,
     DataEA < End.