Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup from unnessesary GSF and GMS dependancies #4

Closed

Conversation

PatrykMis
Copy link

@PatrykMis PatrykMis commented Nov 8, 2021

This references also #3.

GSF, GMS and Play Store

We definitely do not need to have Play Store (and related stuff) references as this app is not an official Play Store release.

Primes

As stated here and in PrimesController.java, this is unnessesary performance metrics tied to Primes library. I also noticed additional improvement in TalkBack performance without Primes. What is done in this matter:

  • removed unnessesary permissions
  • code cleanup from Primes and Primes references
  • TalkBack performance improvements.

Fully tested.

@PatrykMis PatrykMis mentioned this pull request Nov 8, 2021
thestinger and others added 3 commits November 16, 2021 14:47
Bumps gradle from 7.0.2 to 7.0.3.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [aspectjtools](https://github.com/eclipse/org.aspectj) from 1.8.1 to 1.9.7.
- [Release notes](https://github.com/eclipse/org.aspectj/releases)
- [Commits](https://github.com/eclipse/org.aspectj/commits)

---
updated-dependencies:
- dependency-name: org.aspectj:aspectjtools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@PatrykMis
Copy link
Author

PatrykMis commented Apr 12, 2022

Closing since upstream has been updated and it requires different approach.

@PatrykMis PatrykMis closed this Apr 12, 2022
@PatrykMis PatrykMis deleted the grapheneos-gsf_gms branch April 12, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants