Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue adding support for user created subgraphs #2105

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

adamgerhant
Copy link
Collaborator

@adamgerhant adamgerhant commented Nov 10, 2024

Closes #2043

Allows removing, renaming, and reordering imports/exports.
Input based properties for network nodes to allow useable reordering

TODO:

  • Tooltips
  • Into node insertion
  • Rename inputs in properties panel (probably should be deferred)

Copy link

Found Clippy warnings

Clippy Warnings/Errors

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> editor/src/messages/portfolio/document/utility_types/network_interface.rs:846:15
    |
846 |                 get_ports(&modify_import_export_click_target)
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `modify_import_export_click_target`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::needless_borrow)]`

warning: `graphite-editor` (lib) generated 1 warning (run `cargo clippy --fix --lib -p graphite-editor` to apply 1 suggestion)
warning: `graphite-editor` (lib) generated 1 warning (1 duplicate)
warning: `graphite-editor` (lib test) generated 1 warning (1 duplicate)
    Finished `dev` profile [optimized + debuginfo] target(s) in 4m 42s

    Finished `dev` profile [unoptimized + debuginfo] target(s) in 41.31s

@Keavon Keavon force-pushed the modify-import-export branch from 73e1ae5 to 0fbbffd Compare November 12, 2024 22:32
@Keavon Keavon changed the title Continue adding support for user created node graphs Continue adding support for user created subgraphs Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved node graph support for user created nodes
2 participants