-
-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snap and lock angle modifiers for handle dragging to the Path tool #2160
Conversation
!build |
|
@Keavon This PR is now ready for review! |
!build |
|
Please check off the boxes in the issue description for what's implemented now with this PR. |
By now, this PR has implemented all of the listed features. Updated the description as well. Edit:
Please let me know if anything comes up during testing |
QA feedback:
|
Noted. Updated the description to reflect what this PR currently solves. This much should be ready for reviewing and merging. |
b0b79be
to
59635c8
Compare
!build |
|
- Previous implementation broke functionality of using Tab to swap the being-dragged handle to its opposing handle, Now fixed. - Previous implementation broke functionality of using space to drag the manipulator group (anchor + handles) while dragging a handle, Now fixed.
Now, if `shift` is used to snap to a 15° increment, then `ctrl` is used to preserve the angle, releasing the `shift` key will still preserve the angle.
Now, temporarily converts selected handles to colinear if they are not already colinear.
This reverts commit f12ba6f.
59635c8
to
192f314
Compare
!build |
There's one more issue I found, but it can be fixed in the next PR you work on:
|
I will continue the work in a couple days, will fix it then. |
Oh and one more:
Update per your feedback on Discord: instead of restoring the old angle, Ctrl being held down should make the addition of Shift be ignored, thus keeping the locking angle and giving it precedence over the 15 degree angle snapping, until Ctrl is released. |
|
Closes #1870 partly...
This PR aims to close the following parts of #1870 :