Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataNode: rename cluster manager property #18342

Merged
merged 3 commits into from
Feb 21, 2024
Merged

DataNode: rename cluster manager property #18342

merged 3 commits into from
Feb 21, 2024

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Feb 21, 2024 •
edited
Loading

Description

OpenSearch renamed cluster.initial_master_nodes to initial_cluster_manager_nodes, which was not reflected yet and is a possible cause of startup bugs.

opensearch-project/OpenSearch#2769

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise requested review from todvora and moesterheld and removed request for todvora and moesterheld February 21, 2024 08:59
@janheise janheise marked this pull request as draft February 21, 2024 13:00
@janheise janheise marked this pull request as ready for review February 21, 2024 14:19
@janheise janheise requested review from todvora and moesterheld and removed request for todvora February 21, 2024 14:19
moesterheld
moesterheld approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moesterheld moesterheld merged commit 4044665 into master Feb 21, 2024
5 checks passed
@moesterheld moesterheld deleted the datanode/rename_property branch February 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moesterheld moesterheld moesterheld approved these changes

@todvora todvora Awaiting requested review from todvora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janheise @moesterheld