Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display migration error message in RemoteReindexRunning step #20527

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Sep 24, 2024

Motivation and Context

fixes #20461

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 self-assigned this Sep 24, 2024
Copy link
Contributor

@grotlue grotlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however even #20622 doesn't return the error_message yet, but only displays the ERROR status in the progress bar. I would assume, the error would then be passed in the triggerStep
Looks like this needs to be worked on together with backend to provide a working solution.

@todvora
Copy link
Contributor

todvora commented Oct 7, 2024

The RemoteReindexMigration DTO provides a field called "error", which will be extracted from the migration progress. I'd recommend using this field. Even better would be to filter logs for errors and display all of them in the error box. We can filter them by severity, either in the backend or in the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Node Remote Reindexing Migration stuck at "Loading", error visible only in log
4 participants