Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle path prefix when serving web interface assets. (6.1) #21219

Draft
wants to merge 1 commit into
base: 6.1
Choose a base branch
from

Conversation

dennisoelkers
Copy link
Member

Note: This is a backport of #21104 to 6.1.

Description

Motivation and Context

This PR is making sure that if a path prefix is configured through the http_publish_uri (in contrast to through the X-Graylog-Server-URL header), it will be considered when looking up assets.

Fixes #21015.

How Has This Been Tested?

It has been tested with configuring http_publish_uri with and without a path prefix, with a trailing slash and without it and without the directive at all.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

* Handle path prefix when serving web interface assets.

* Adding tests for frontend asset consistency.

* Adding changelog snippet.
@dennisoelkers dennisoelkers marked this pull request as draft December 23, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant