Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watt-time: README: fixed latitude->location, added explanation of eff… #15

Merged
merged 2 commits into from
Dec 31, 2023
Merged

watt-time: README: fixed latitude->location, added explanation of eff… #15

merged 2 commits into from
Dec 31, 2023

Conversation

pazbardanl
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • watt-time: README: fixed latitude->location, added explanation of effect and position in impl

jmcook1186
jmcook1186 approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm- thanks!

@jmcook1186 jmcook1186 merged commit c253e0b into main Dec 31, 2023
2 checks passed
@jmcook1186 jmcook1186 deleted the watttime-readme-tweaks branch December 31, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@gnanakeethan gnanakeethan gnanakeethan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pazbardanl @gnanakeethan @jmcook1186