Refactors watt-time model #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import {ERRORS} from '../../util/errors'; | ||
| import {buildErrorMessage} from '../../util/helpers'; | ||
|
|
||
| import {KeyValuePair, ModelParams} from '../../types/common'; | ||
| import {ModelPluginInterface} from '../../interfaces'; | ||
| import {WattTimeAPI} from './watt-time-api'; | ||
| import {validate} from '../../util/validations'; |
There was a problem hiding this comment.
please separate util, api imports from types
There was a problem hiding this comment.
thanks for noticing
src/lib/watt-time/watt-time-api.ts
Outdated
| * Sorts the data based on the 'point_time' property in ascending order. | ||
| */ | ||
| private sortData(data: object[]) { | ||
| return data.sort((a: any, b: any) => { |
There was a problem hiding this comment.
please cover a and b with types
jmcook1186
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request