Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage #67

Closed
wants to merge 21 commits into from
Closed

Add test coverage #67

wants to merge 21 commits into from

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Apr 1, 2024

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add full test coverage for all plugins except watt-time, there is a watt-time improvement PR where the logic has been changed
  • add minor improvement

manushak added 21 commits March 18, 2024 16:43
@manushak
test(lib): add test coverage for azure-importer plugin
396180b
@manushak
fix(lib): add deprecated tag to the teads-aws plugin
407fbc5
@manushak
test(lib): add test coverage for co2js
676e7bc
@manushak
test(mocks): add mock data for watt-time plugin
25627c5
@manushak
feat(mocks): add mocks for watt-time
73f22b8
@manushak
fix(lib): mior fix in watt-time api
5de6f5b
@manushak
test(lib): add test coverage for watt-time plugin
9b936ac
@manushak
test(util): add tests for validations.ts
9bb516f
@manushak
feat(mocks): add condition to mocks of boavizta data
d5e7ac2
@manushak
fix(lib): rename staticParams into input in boavizta
619fa43
@manushak
test(lib): add test coverage for boavizta plugin
66e0393
@manushak
test(lib): add missing test in ccf
d9ff185
@manushak
test(lib): add test coverage of ccf plugin
9d9bc89
@manushak
feat(lib): improve ccf validation
a84135d
@manushak
test(lib): add full test coverage for boavizta plugin
0b979c7
@manushak
feat(lib): change properties's conditional check to optional check
df19461
@manushak
test(lib): add full test coverage for co2js
4428b09
@manushak
fix(lib): make some minor improvment
73b990f
@manushak
test(lib): add full test coverage for azure-importer
3a396b8
@manushak
test(lib): update test description of azure-importer
1e966aa
@manushak
fix(lib): change properties's conditional check to optional check
d45a7bb
@manushak manushak mentioned this pull request Apr 1, 2024
Closed
@manushak manushak added tests related to unit or integration tests medium-severity medium severity issue size: large task requiring a lot of dev time awaiting-dev-review PR is awaiting review from core dev labels Apr 1, 2024
@narekhovhannisyan
Copy link
Member

@manushak please provide unit test PRs in separate logical chunks like one for boavizta, the next one for ccf, and so on. It's difficult to review.

@manushak manushak marked this pull request as draft April 2, 2024 07:51
@manushak manushak closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narekhovhannisyan narekhovhannisyan Awaiting requested review from narekhovhannisyan

@jmcook1186 jmcook1186 Awaiting requested review from jmcook1186

@MariamKhalatova MariamKhalatova Awaiting requested review from MariamKhalatova

Assignees
No one assigned
Labels
awaiting-dev-review PR is awaiting review from core dev medium-severity medium severity issue size: large task requiring a lot of dev time tests related to unit or integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manushak @narekhovhannisyan