Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leave location validation to specific carbon API #56

Merged
merged 8 commits into from
Aug 1, 2023
Merged

Leave location validation to specific carbon API #56

merged 8 commits into from
Aug 1, 2023

Commits on Jul 26, 2023

  1. raise InvalidLocationError if unknown postcode 

    This is assuming that the _only_ way of getting None as a response
object is by supplying an unknown postcode to the carbonintensity api
    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ff26ac4 View commit details
    Browse the repository at this point in the history

  2. Leave location validation to the API

    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    560c214 View commit details
    Browse the repository at this point in the history

  3. exit program execution on invalid location

    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    27d1157 View commit details
    Browse the repository at this point in the history

  4. test: InvalidLocationError is raised on bad postcode

    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    ab7ce0d View commit details
    Browse the repository at this point in the history

  5. Accept two part postcodes (space-separated)

    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6c608c6 View commit details
    Browse the repository at this point in the history

  6. Remove extra calls to 'validate_location'

    @tlestang
    tlestang committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    997548f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Specify location format on InvalidLocationError (UK)

    @tlestang
    tlestang committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b68b23c View commit details
    Browse the repository at this point in the history

  2. Truncate long form postcode and warn user (UK)

    @tlestang
    tlestang committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    8041bcc View commit details
    Browse the repository at this point in the history