Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImageHandling.php, add fallbackImage var. #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asistent0
Copy link

Fix problem "Creation of dynamic property Gregwar\ImageBundle\Services\ImageHandling::$fallbackImage is deprecated"

Fix problem "Creation of dynamic property Gregwar\ImageBundle\Services\ImageHandling::$fallbackImage is deprecated"
@alexbusu
Copy link

alexbusu commented Jan 8, 2024

@Gregwar let's have this one merged, please :)

@joesenova
Copy link

joesenova commented Oct 30, 2024

Can we change the constructor to following:

public function __construct(private string $cacheDirectory, private int $cacheDirMode, private string $handlerClass, private ContainerInterface $container, private Packages $assetsPackages, private KernelInterface|FileLocatorInterface $fileLocator, private bool $throwException, private string $fallbackImage)

Then also if you can add the return type of the ::load() method to void

That will solve the deprecation messages for Symfony 6.4.* and 7.0

@Gregwar Is there any chance we can get this merged is with the changes I am suggesting above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants