Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for tls connection #15

Merged
merged 2 commits into from
Feb 29, 2024
Merged

feat: add support for tls connection #15

merged 2 commits into from
Feb 29, 2024

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Feb 29, 2024

changes included in this patch:

  • add tls-roots feature to tonic to include system ca
  • make custom ca/client certs optional when configuring tls
  • correct endpoint scheme when tls enabled

@sunng87 sunng87 requested a review from fengjiachun February 29, 2024 11:07
@sunng87 sunng87 self-assigned this Feb 29, 2024
fengjiachun
fengjiachun approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun merged commit d21dbcf into master Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees

@sunng87 sunng87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunng87 @fengjiachun