refactor(defaulting): modify the default startup period seconds: 5s -…

…> 1s to speed up the startup
GreptimeTeam · Dec 3, 2024 · 18cf111 · 18cf111
1 parent 3b0b025
commit 18cf111
Show file tree

Hide file tree

Showing 7 changed files with 26 additions and 24 deletions.
diff --git a/apis/v1alpha1/defaulting.go b/apis/v1alpha1/defaulting.go
@@ -398,11 +398,13 @@ func defaultStartupProbe() *corev1.Probe {
 				Port: intstr.FromInt32(DefaultHTTPPort),
 			},
 		},
-		PeriodSeconds: 5,
 
-		// The StartupProbe can try up to 60 * 5 = 300 seconds to start the container.
-		// For some scenarios, the datanode may take a long time to start, so we set the failure threshold to 60.
-		FailureThreshold: 60,
+		// Check for the health endpoint every second to speed up the startup.
+		PeriodSeconds: 1,
+
+		// The StartupProbe can try up to 300 * 1 = 300 seconds(5 minutes) to start the container.
+		// For some scenarios, the datanode may take a long time to start, so we set the failure threshold to 300.
+		FailureThreshold: 300,
 	}
 }
 

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/merge/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/merge/test00/expect.yaml
@@ -43,8 +43,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
   frontend:
     replicas: 1
     httpPort: 9000
@@ -81,8 +81,8 @@ spec:
           httpGet:
             path: /health
             port: 9000
-          periodSeconds: 5
-          failureThreshold: 60
+          periodSeconds: 1
+          failureThreshold: 300
         resources:
           limits:
             cpu: 100m
@@ -125,8 +125,8 @@ spec:
           httpGet:
             path: /health
             port: 4000
-          periodSeconds: 5
-          failureThreshold: 60
+          periodSeconds: 1
+          failureThreshold: 300
         resources:
           limits:
             cpu: 50m
@@ -173,8 +173,8 @@ spec:
           httpGet:
             path: /health
             port: 4000
-          periodSeconds: 5
-          failureThreshold: 60
+          periodSeconds: 1
+          failureThreshold: 300
         resources:
           limits:
             cpu: 100m

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test00/expect.yaml
@@ -36,8 +36,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
   frontend:
     replicas: 1
     httpPort: 4000

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test01/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test01/expect.yaml
@@ -36,8 +36,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
       resources:
         requests:
           cpu: "500m"

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test02/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test02/expect.yaml
@@ -47,8 +47,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
   frontend:
     replicas: 1
     httpPort: 4000

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test03/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test03/expect.yaml
@@ -23,8 +23,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
   version: latest
   initializer:
     image: greptime/greptimedb-initializer:latest
@@ -114,8 +114,8 @@ spec:
             httpGet:
               path: /health
               port: 4000
-            periodSeconds: 5
-            failureThreshold: 60
+            periodSeconds: 1
+            failureThreshold: 300
       datanodeStorage:
         dataHome: /data/greptimedb
         fs:

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbstandalone/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbstandalone/test00/expect.yaml
@@ -28,8 +28,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 5
-        failureThreshold: 60
+        periodSeconds: 1
+        failureThreshold: 300
   service:
     type: ClusterIP
   logging: