chore: modify default values of startup probe

GreptimeTeam · Oct 25, 2024 · 272c727 · 272c727
1 parent 9bd069d
commit 272c727
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -29,6 +29,10 @@ The GreptimeDB Operator includes, but is not limited to, the following features:
 
   Bootstrap the GreptimeDB monitoring stack for the GreptimeDB cluster by providing the `monitoring` field in the `GreptimeDBCluster` CR.
 
+## Prerequisites
+
+The GreptimeDB Operator requires at least Kubernetes `1.18.0`.
+
 ## Quick Start
 
 The fastest way to install the GreptimeDB Operator is to use `bundle.yaml`:

diff --git a/apis/v1alpha1/defaulting.go b/apis/v1alpha1/defaulting.go
@@ -385,11 +385,11 @@ func defaultStartupProbe() *corev1.Probe {
 				Port: intstr.FromInt32(DefaultHTTPPort),
 			},
 		},
-		PeriodSeconds: 10,
+		PeriodSeconds: 5,
 
-		// The StartupProbe can try up to 30 * 10 = 300 seconds to start the container.
-		// For some scenarios, the database may take a long time to start, so we set the failure threshold to 30.
-		FailureThreshold: 30,
+		// The StartupProbe can try up to 60 * 5 = 300 seconds to start the container.
+		// For some scenarios, the datanode may take a long time to start, so we set the failure threshold to 60.
+		FailureThreshold: 60,
 	}
 }
 

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/merge/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/merge/test00/expect.yaml
@@ -43,8 +43,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
   frontend:
     replicas: 1
     httpPort: 9000
@@ -78,8 +78,8 @@ spec:
           httpGet:
             path: /health
             port: 9000
-          periodSeconds: 10
-          failureThreshold: 30
+          periodSeconds: 5
+          failureThreshold: 60
         resources:
           limits:
             cpu: 100m
@@ -119,8 +119,8 @@ spec:
           httpGet:
             path: /health
             port: 4000
-          periodSeconds: 10
-          failureThreshold: 30
+          periodSeconds: 5
+          failureThreshold: 60
         resources:
           limits:
             cpu: 50m
@@ -164,8 +164,8 @@ spec:
           httpGet:
             path: /health
             port: 4000
-          periodSeconds: 10
-          failureThreshold: 30
+          periodSeconds: 5
+          failureThreshold: 60
         resources:
           limits:
             cpu: 100m

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test00/expect.yaml
@@ -36,8 +36,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
   frontend:
     replicas: 1
     httpPort: 4000

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test01/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test01/expect.yaml
@@ -36,8 +36,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
       resources:
         requests:
           cpu: "500m"

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test02/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test02/expect.yaml
@@ -47,8 +47,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
   frontend:
     replicas: 1
     httpPort: 4000

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test03/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbcluster/setdefaults/test03/expect.yaml
@@ -23,8 +23,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
   version: latest
   initializer:
     image: greptime/greptimedb-initializer:latest
@@ -101,8 +101,8 @@ spec:
             httpGet:
               path: /health
               port: 4000
-            periodSeconds: 10
-            failureThreshold: 30
+            periodSeconds: 5
+            failureThreshold: 60
       datanodeStorage:
         dataHome: /data/greptimedb
         fs:

diff --git a/apis/v1alpha1/testdata/defaulting/greptimedbstandalone/test00/expect.yaml b/apis/v1alpha1/testdata/defaulting/greptimedbstandalone/test00/expect.yaml
@@ -28,8 +28,8 @@ spec:
         httpGet:
           path: /health
           port: 4000
-        periodSeconds: 10
-        failureThreshold: 30
+        periodSeconds: 5
+        failureThreshold: 60
   service:
     type: ClusterIP
   logging: