Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(otlp): initial OTLP trace support #2627

Merged
merged 19 commits into from
Oct 23, 2023
Merged

feat(otlp): initial OTLP trace support #2627

merged 19 commits into from
Oct 23, 2023

Conversation

yuanbohan
Copy link
Contributor

@yuanbohan yuanbohan commented Oct 20, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

support OTLP traces

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • help GreptimeDB to be the backend of OTLP traces
  • the traces support is in preview, and it will be updated after Map or List type and index are supported by GreptimeDB, and the table name traces_preview_v01 will be updated too.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 changed the title feat(otlp): support trace feat(otlp): initial OTLP trace support Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

Merging #2627 (ba33199) into develop (6e87ac0) will decrease coverage by 0.80%.
Report is 24 commits behind head on develop.
The diff coverage is 72.09%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2627      +/-   ##
===========================================
- Coverage    85.33%   84.53%   -0.80%     
===========================================
  Files          737      743       +6     
  Lines       118030   120401    +2371     
===========================================
+ Hits        100724   101785    +1061     
- Misses       17306    18616    +1310

sunng87
sunng87 reviewed Oct 20, 2023
View reviewed changes
src/servers/src/otlp/trace.rs Outdated Show resolved Hide resolved
src/servers/src/otlp/trace.rs Outdated Show resolved Hide resolved
@yuanbohan yuanbohan requested a review from sunng87 October 20, 2023 10:58
@fengys1996 fengys1996 requested a review from shuiyisong October 23, 2023 02:13
@yuanbohan yuanbohan added this pull request to the merge queue Oct 23, 2023
Merged via the queue into GreptimeTeam:develop with commit 44280f7 Oct 23, 2023
12 checks passed
@yuanbohan yuanbohan deleted the feat/otlp_tracing branch October 23, 2023 06:50
@killme2008 killme2008 added the docs-required This change requires docs update. label Oct 24, 2023
@sunng87 sunng87 mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuiyisong shuiyisong shuiyisong approved these changes

@sunng87 sunng87 sunng87 approved these changes

@fengys1996 fengys1996 Awaiting requested review from fengys1996

Assignees
No one assigned
Labels
docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuanbohan @sunng87 @shuiyisong @killme2008 @fengys1996