-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: parse Loki labels in protobuf write path #5305
perf: parse Loki labels in protobuf write path #5305
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5305 +/- ##
==========================================
- Coverage 84.11% 83.87% -0.24%
==========================================
Files 1202 1202
Lines 225933 226022 +89
==========================================
- Hits 190033 189575 -458
- Misses 35900 36447 +547 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geat work! A few suggestions applied.
b148f6e
to
86ea81b
Compare
86ea81b
to
ce7f7dd
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5287
What's changed and what's your intention?
Parse Loki labels directly in protobuf write path instead of converting and decoding using JSON5, roughly 10x better performance-wise while ensuring correctness.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.