-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integration): add pg kvbackend #5331
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
GT_POSTGRES_ENDPOINTS: postgres://greptimedb:[email protected]:5432/postgres | ||
GT_KAFKA_ENDPOINTS: 127.0.0.1:9092 | ||
GT_KAFKA_SASL_ENDPOINTS: 127.0.0.1:9093 | ||
UNITTEST_LOG_DIR: "__unittest_logs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will double our runner time and CI cost. We need figure out a way to run this effectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not double actually, but still quite slow
Besides, I doubt if the pg kvbackend is actually running, I didn't see the info logs that tells me which backend it's using...
If we'd like to run integration test over pg kvbackend, the cost seems unevitable. I wonder if there's a method that we can run it when something related to pg_kvbackend features have been changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to a separated task that uses free runner (ubuntu-latest
) to see if it's capable to run this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite reasonable for me. I'll have a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remember to change the command from cargo test integration
to cd tests-integration && cargo nextest run
. This will reduce test binaries required to compile and link.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5331 +/- ##
==========================================
- Coverage 84.14% 83.90% -0.25%
==========================================
Files 1181 1181
Lines 220905 220905
==========================================
- Hits 185882 185351 -531
- Misses 35023 35554 +531 |
Some of the integration test do not require a distributed databases then we don't need a pg kvbackend for it. Since sqlness test for pg kvbackend has been added, we can hold this for now to see if there's other solution. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#5208
What's changed and what's your intention?
Add pg kvbackend for integration test. Not quite sure if it's alright to do like this.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.