GROUP-105 Updated configuration to correctly identify root certs paths #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This pull request solves two issues with how the root certificate for the Postgres server is passed to the R2DBC and JDBC drivers.
R2DBC Driver Handling of sslRootCert Property
The driver searches in the classpath by default. Providing a the
classpath:prefix should then be avoided. If the file cannot be found in the classpath, it's searched as a normal file URL.Source
JDBC Driver Handling of sslRootCert Property via Flyway
The driver seems to use the
classpath:prefix. However, we have to provide the certificate path via the URL, since Flyway Community Edition does not support JDBC properties passed through the YML configuration.