Add table for weather observation (Stacked PR) #3452
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloCkWeRX
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| flash[:notice] = I18n.t('weather_observations.created') if @weather_observation.save | ||
| respond_with(@weather_observation) | ||
| end | ||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| flash[:notice] = I18n.t('weather_observations.updated') if @weather_observation.update(weather_observation_params) | ||
| respond_with(@weather_observation) | ||
| end | ||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| flash[:notice] = I18n.t('weather_observations.deleted') | ||
| redirect_to(member_weather_observations_path(@weather_observation.owner)) | ||
| end | ||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| end | ||
|
|
||
| private | ||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| params.require(:weather_observation).permit! | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Expected a newline at the end of the file.
| params.require(:weather_observation).permit! | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| = render 'weather_observations/actions', weather_observation: weather_observation | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Unexpected trailing spaces found.
| %strong= @weather_observation | ||
| .col-md-3.col-12 | ||
| = render 'weather_observations/actions', weather_observation: @weather_observation | ||
| .row |
There was a problem hiding this comment.
The line was indented 2 levels deeper than the previous line.
| @@ -0,0 +1,18 @@ | |||
| - if can?(:edit, garden) | |||
| .dropdown.garden-actions | |||
| %a#garden-actions-button.btn.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-toggle" => "dropdown", type: "button", href: '#'} Actions | |||
| @@ -0,0 +1,18 @@ | |||
| - if can?(:edit, garden) | |||
| .dropdown.garden-actions | |||
| %a#garden-actions-button.btn.dropdown-toggle{"aria-expanded" => "false", "aria-haspopup" => "true", "data-toggle" => "dropdown", type: "button", href: '#'} Actions | |||
There was a problem hiding this comment.
Hash attribute should start with one space after the opening brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3453 first
A small part of:
#1165
#863
Also kind of like:
https://github.com/Growstuff/growstuff/pull/1307/files
Based on schemaorg/schemaorg#362
The idea would be to only record specific observations, with a source that have happened.
Ideally this would be from either:
Use cases:
As gardener with various observation tools
I would like to record a snapshot of weather (manually)
So that I have a history of what was happening in my own microclimate
And I can compare to crop yields.
As gardener with home automation
I would like to record a snapshot of weather
So that I have a history of what was happening in my own microclimate
And I can compare to crop yields.