Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classes needed for lambda merging in ProGuard #36
base: master
Are you sure you want to change the base?
Classes needed for lambda merging in ProGuard #36
Changes from 31 commits
ca6936c
f0ed6b2
7f1f0af
b626bfc
e92a27b
2acc29c
e61c38d
e39c05e
5f24388
3338829
4f74d43
0d9cb78
8c81564
ea25197
fc68b07
cd4a6a3
5550c96
9860f9e
fcfa75e
a33e5da
bf8155b
b2877ea
9d3bb0c
8c82796
758be93
528e7a7
7821839
b542b9b
99065f7
4ef0e59
67cde7f
72a80b9
7eeff48
02e8fd0
660a391
59f7999
7d34770
7441f81
082b3a8
31f231d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the ProGuardCORE header to all the classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be replacable by the following
Filter
class which can delegate to anotherClassVisitor
if the the class is referenced.It's extracted from
proguard.backport.StaticInterfaceMethodConverter.MyReferencedClassFilter
in ProGuard.Usable like the following:
But I see that
currentLambdaClass
gets updated, so might not work. Can also be used with aClassCounter
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a class like this already but it's not in ProGuardCORE at the moment. There's already the
Counter
interface to use with these counting visitors.Can you move this also into the attribute/visitor package, since it's an
AttributeVisitor
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we should be using a
ConstantPoolEditor
to add a new constant. You can use aConstantPoolShrinker
after to remove unused ones.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seems quite specific to the lambda merging, can you move it to ProGuard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all visitors copied to
proguard.classfile.visitor
or would you like them to be part of the package that contains the lambda merging code?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, most of them (like this one) seem to belong in the lambda package since they aren't ready for general use.