Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON5 support #144

Open
autonomobil opened this issue Apr 23, 2023 · 2 comments
Open

JSON5 support #144

autonomobil opened this issue Apr 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@autonomobil
Copy link

Currently it doesn't work for .json5 files, is there a possibility to add support for json5?
@Gudahtt Gudahtt added the enhancement New feature or request label Jul 10, 2023
@autonomobil
Copy link
Author

any uodate by any chance?

Gudahtt added a commit that referenced this issue Dec 2, 2024
@Gudahtt
refactor: Refactor how parser is constructed
49a3c60 
Refactor how the JSON parser is constructed, how options are parsed,
and how the sort compare function is created. These are each handled by
separate functions now, rather than being inlined into the custom
parser.

This is intended to make it easier to extend different types of JSON
parsers (e.g. #144).
@Gudahtt Gudahtt mentioned this issue Dec 2, 2024
Merged
Gudahtt added a commit that referenced this issue Dec 2, 2024
@Gudahtt
refactor: Refactor how parser is constructed
6161d29 
Refactor how the JSON parser is constructed, how options are parsed,
and how the sort compare function is created. These are each handled by
separate functions now, rather than being inlined into the custom
parser.

This is intended to make it easier to extend different types of JSON
parsers (e.g. #144).
Gudahtt added a commit that referenced this issue Dec 2, 2024
@Gudahtt
refactor: Refactor how parser is constructed (#249)
4db3d25 
Refactor how the JSON parser is constructed, how options are parsed,
and how the sort compare function is created. These are each handled by
separate functions now, rather than being inlined into the custom
parser.

This is intended to make it easier to extend different types of JSON
parsers (e.g. #144).
@Gudahtt
Copy link
Owner

Gudahtt commented Dec 2, 2024

This should be relatively easy to support, given that JSON5 shares the same Prettier parser as JSON.

I did some refactoring in #249 to make this easier, but haven't had time to explore this yet. I can come back to this sometime in the future, but if you or someone else wants to give it a try, please feel free!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gudahtt @autonomobil