refactor: Refactor how parser is constructed #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor how the JSON parser is constructed, how options are parsed, and how the sort compare function is created. These are each handled by separate functions now, rather than being inlined into the custom parser. This is intended to make it easier to extend different types of JSON parsers (e.g. #144).
Gudahtt
force-pushed
the
refactor-parser-creation
branch
from
49a3c60 to
6161d29
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor how the JSON parser is constructed, how options are parsed, and how the sort compare function is created. These are each handled by separate functions now, rather than being inlined into the custom parser.
This is intended to make it easier to extend different types of JSON parsers (e.g. #144).