Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SlimeFrame fast foundry #26

Merged
merged 2 commits into from
Jan 6, 2024
Merged

feat: add SlimeFrame fast foundry #26

merged 2 commits into from
Jan 6, 2024

Conversation

VoperAD
Copy link
Contributor

@VoperAD VoperAD commented Jan 6, 2024

Description

It basically adds support for SlimeFrame (new dependency in pom.xml) and a new fast machine for the multiblock "Foundry" from SlimeFrame.

Proposed changes

  • New fast machine: Fast SlimeFrame Foundry

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

No documentation was added, I just followed the pattern used in the creation of the fast infinity workbench.

Copy link
Member

@ybw0014 ybw0014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! One small change is needed here.

src/main/java/net/guizhanss/fastmachines/setup/Items.java Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@VoperAD
Copy link
Contributor Author

VoperAD commented Jan 6, 2024

Done! I have just fixed it.

Copy link
Member

@ybw0014 ybw0014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ybw0014 ybw0014 changed the title Add SlimeFrame fast foundry feat: add SlimeFrame fast foundry Jan 6, 2024
@ybw0014 ybw0014 merged commit 32989f8 into GuizhanCraft:master Jan 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants